Fix Ogmios connection errors #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error would take place when the Ogmios service is started with an invalid socket file. The Ogmios service is able to start and receive connections but the handshake is never completed and the client errors out when trying to send frames. The fix was added to the underlying websocket_client library and this commit simply updates Xogmios to point to the patched version.
caike
commented
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors would take place when there were issues with the underlying Cardano node - typically when the node is still starting and not yet fully synced. The Ogmios service is able to start and receive connections but the handshake is never completed and the client errors out when trying to send frames.
With this fix, Xogmios now displays errors/warnings for the following:
Fixes #42